[core] Allow blob inline fields without blob-field#7827
Merged
leaves12138 merged 2 commits intoMay 13, 2026
Merged
Conversation
leaves12138
changed the title
| if (blobFields.contains(name) || blobViewFields.contains(name)) { | ||
| if (blobFields.contains(name) | ||
| || blobDescriptorFields.contains(name) | ||
| || blobViewFields.contains(name)) { |
Contributor
There was a problem hiding this comment.
nit: Could we extract a shared blobTypeFields() helper like FlinkCatalog
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
blob-descriptor-fieldandblob-view-fieldalready fully describe descriptor/view BLOB semantics, so users should not need to repeat those fields inblob-field.Changes
blob-descriptor-fieldandblob-view-fieldno longer need to be subsets ofblob-field.blob-descriptor-fieldorblob-view-fieldas BLOB fields during Flink and Spark table creation.blob-fieldstill works.blob-field.Tests
mvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=BlobTableTest#testBlobInlineFieldCanDeclareBlobWithoutBlobField testmvn -pl paimon-flink/paimon-flink-common -am -Pfast-build -DfailIfNoTests=false -Dtest=BlobTableITCase#testWriteBlobViewWithBuiltInFunction+testBlobInlineFieldCanDeclareBlobWithoutBlobField testmvn -Pspark3 -pl paimon-spark/paimon-spark-common,paimon-spark/paimon-spark3-common,paimon-spark/paimon-spark-ut -am -Pfast-build -DfailIfNoTests=false -DwildcardSuites=org.apache.paimon.spark.sql.BlobTestWithV2Write -Dtest=none testhugo -b "" --quietgit diff --checkJAVA_HOME=/opt/jdk-11.0.18.jdk/Contents/Home mvn -pl paimon-flink/paimon-flink-common -am -Pflink-2.2 -Pfast-build -DskipTests compile